Multiple vulnerabilities in Regexp and String case conversion (ruby-lang.org)

178 points by runesoerensen 6 hours ago

54 comments:

by tptacek 5 hours ago

There's what I think is probably an awesome bug here.

Windows-1252 encoding has a representation for lowercase German sharp 's' (ß), but not one for the uppercase. If you upcase a string containing a sharp 's', it gets normalized to "SS", which increases the length of the string by one character. The 1252 case conversion code doesn't handle this; it looks like it checks for headroom in the buffer one character at a time. So if the last character of a string you upcase is ß, it looks like you get a one-byte overflow (of 'S').

If that's really the bug (there's a claimed RCE POC), the heap grooming for it must be really fussy! I couldn't find any other character pairs that expand like this.

You can feed strings in 1252 to a Rails program through multipart POSTs, which get to pick their encodings.

The great thing about this bug, apart from how it illustrates how doomed we all are (if I'm right), is that it should by rights have the best vulnerability name of the year, because you get to work 'ß' into it.

by bee_rider 4 hours ago

Haha, that exact character caused problems in a programming class I tutored for. Got to throw the first year students some curveballs.

by testplzignore 5 hours ago

I wonder if there is a similar bug for U+0130 which (I think) expands to two characters when lowercased.

by throw-the-towel 7 minutes ago

Wait, why would the Turkish dotted uppercase I expand to two characters?

by tptacek 5 hours ago

Maybe somewhere! But that character isn't in Windows-1252 at all, so it can't trip this string counting bug.

by xp84 5 hours ago

Should we call it #upcaße2Shell?

by tptacek 5 hours ago

One of the discoverers suggested, on Twitter, Ruby2ßhell. My wife, who speaks and writes German, refused to entertain this.

by watersb 3 hours ago

> it should by rights have the best vulnerability name of the year, because you get to work 'ß' into it.

Holy sh!t

by juliusdavies 2 hours ago

Holy Scheiße

by dwattttt 2 hours ago

As is tradition, Raymond Chen has had something to say about this. The windows-1252 code page was introduced with Windows 1.0, and according to Wikipedia its final version shipped with Win98. String operations are just plain too hard.

https://devblogs.microsoft.com/oldnewthing/20200804-00/?p=10...

https://devblogs.microsoft.com/oldnewthing/20241007-00/?p=11...

by throw-the-towel a few seconds ago

I'm mortified by the second article, C++ really is Lovecraftian-level insanity.

by tptacek an hour ago

There is no good reason for really any Rails app to accept Windows-1252! This is reminiscent of the YAML vulnerability, which surprised most Rails users with the fact that Rails endpoints all accepted YAML to begin with.

by timcobb 5 minutes ago

What if I am reading old ID3 tags and posting them verbatim to my rails app? Should I be detecting encodings and converting to utf8 before rails?

by kps 2 hours ago

values of ß will give rise to dom

by cowlevel 5 hours ago

Unicode also has this feature because SS is the correct uppercase form of ß

by eviks 2 hours ago

Not only that, when you uppercase 1 char with precomposed diacritics, but uppercase doesn't have precomposed diacritics, so they expand into separate chars (max is 1 to 3 chars)

Both fixable, but as with a lot of Unicode stuff, might take a long while

by p-e-w 4 hours ago

It’s not. There are multiple uppercase forms, including “SS”, “SZ”, and the uppercase ß character, all of which are well-established, which makes all of them correct according to the principle of linguistic descriptivism.

by ben-schaaf 2 hours ago

And according to linguistic perscriptivism, the upper case of ß is ẞ since 2017. (SS is also allowed, but no longer preferred)

by Georgelemental 3 hours ago

But according to the "principle" of blindly following the Unicode standard with no tailoring, the "correct" form is SS. (And Unicode's stability guarantees preclude ever changing it to ẞ)

by edflsafoiewq 3 hours ago

>And Unicode's stability guarantees preclude ever changing it to ẞ

This seems like a bad property for a system that encodes human writing systems.

by pmontra 2 hours ago

Human writing systems themselves have that very same property. The stability of written language prevents them to adapt swiftly to changes to spoken language.

Knight / night is an example for English. That k should be gone, right? Or all those silent -ment and e in French.

Enter the computer and I'm not surprised that German speakers end up mostly with SS because that's what computers do when automatically upcasing words.

A lot of spelling changes are dictated by what's available on keyboards. In Italian we accept E' as È because we don't have that upper case character on our keyboard. Automatic uppercase on start of sentences fixed it where it's available and mobile keywords show an È as an option of you long press a shifted e. But what if you are writing Italian in an English locale form field with a hardware keyboard (here with an OS with English locale) or you have to write È in the middle of a sentence or, go back 30 or 40 years, you have to use a typing machine?

I'm am sure that every language that had to go through a phase of adapting to ASCII and to the limits on the layout of keyboards has similar stories to tell.

by eviks 2 hours ago

What stops you from blindly following the standard with tailoring?

by frangonf 4 hours ago

Or so the Germans would have us believe...

by SoftTalker 28 minutes ago

I've been saying that for years.

by sscaryterry 4 hours ago

Who cares, I use ASCII :)

by pentestercrab 3 hours ago

  str = ("\x82\xA0" + ("A" * (2**32 + 4))).force_encoding(Encoding::Shift_JIS)
  
  puts "str.bytesize: #{str.bytesize}"
  puts "str.encoding: #{str.encoding}"
  puts "str.valid_encoding?: #{str.valid_encoding?}"
  
  new_str = str.downcase
  
  puts "new_str.bytesize: #{new_str.bytesize}"
  puts "new_str.bytes:    #{new_str.bytes}"
  puts "new_str.encoding: #{new_str.encoding}"
outputs on an unfixed version:

  str.bytesize: 4294967302
  str.encoding: Shift_JIS
  str.valid_encoding?: true
  new_str.bytesize: 6
  new_str.bytes:    [130, 160, 97, 97, 97, 97]
  new_str.encoding: Shift_JIS
also I'd suggest you check out CVE-2026-128084 (GHSA-4fqr-96q8-xrfx) if you are interested in C bugs impacting Ruby on Rails
by lousken 6 hours ago

I need a vacation

by donkey_brains 6 hours ago

We all do, but we don’t know if our companies will still be there when we get back.

by darknavi 7 minutes ago

maybe that's ok. We can just burn it down and restart ("make no mistakes" right??)

by cwmoore 5 hours ago

I hear Java is nice

by layer8 5 hours ago

You can find nice shells on the beaches.

by NooneAtAll5 5 hours ago

java had vulnerability in base64 decode asm

https://calif.io/java4shell/

by koolba 4 hours ago

We’re all fools for thinking something as inherently dangerous as decoding a base64 string or converting it to upper case should be performed in a non-airgapped environment.

by vbezhenar an hour ago

Thankfully my servers are too old for this vulnerability to work.

by cheeze 3 hours ago

> Java RCE/Memory Corruption

> OpenJDK13

Serves those cutting edge technology adopters right. I'm sitting on JDK8 baby!

by dboreham 2 hours ago

Right with you.

by saghm 4 hours ago

A full day ago! Practically ancient

by _pdp_ 5 hours ago

Book it for 18 months from now. Oh, also bring your laptop.

by rvz 3 hours ago

These are all C-based memory corruption vulnerabilities.

The reality of these type of bugs being found by autonomous AI models on established software should tell you by now that memory-unsafe languages are completely exposed.

This is who maintainers you are up against:

"Thanks to Stephan Lipp (Ada Logics) and Anthropic for reporting this issue."

Imagine attackers using abliterated models at scale who don't disclose these issues.

[0] https://github.com/ruby/ruby/security/advisories/GHSA-34m4-m...

by Gigachad 2 hours ago

We have been screaming this for years before AI showed up. But instead of removing C wherever possible it was decided fine to just patch the bugs as they showed up.

by skybrian 37 minutes ago

I imagine Ruby programmers thought they were working in a memory-safe language, but apparently that's not enough?

by userbinator 2 hours ago

Imagine developers using abliterated models and fixing these issues before releasing any more code.

by slopinthebag 3 hours ago

oh boy. if only we had a language that could prevent this from happening. oh well, i guess there is nothing we can do but patch these things once they're discovered.

by baggy_trough 2 hours ago

exactly, which is why I use ruby.

by Gigachad 3 hours ago

"There's no way this could be prevented", says users of only programming language where it regularly happens

by slopinthebag 3 hours ago

good developers simply would not have written these bugs.

by Spivak 2 hours ago

Just completely rewrite CRuby which includes a JIT and has to maintain ABI compatibility for compiled extensions. I mean I'm certainly not volunteering for that project.

by ethin 2 hours ago

Oh boy if you could develop a solution that would port C code over with completely safe rust semantics where feasible and without people having to clean up the disaster of a result, that would be nice, instead of you guys trying to demonstrate how superior you and your favorite language are. Because that is the only way you are going to port the world to Rust. Oh, and you have to support COBOL too. Probably a bunch of other old languages that have been around for longer than a lot of us have been alive.

Seriously, all these snarky posts about Rust being the god language really comes off as "look how utterly superior we are as Rust programmers and look how superior the Rust language is, this would never ever happen in Rust the god language". Yes, I'm annoyed by stuff like this.

by slopinthebag 2 hours ago

actually rust devs are humble enough to understand their limitations and let the compiler help them out.

as for porting, well, llm go burrrrrr. we can even use llms to port gpl to mit.

by TZubiri 5 hours ago

It should be pretty straightforward to replace regexes with good ole ifs, array acceses, and comparision operators, whether manually or with an LLM. Pretty low hanging fruit to shave off some kilobytes of attack vector

by preinheimer 4 hours ago

I think you’re underestimating the complexity of a lot of regular expressions.

by marcus_holmes 4 hours ago

Also that a lot of the regexes will be inside Rails code that we can't touch, Gems that need maintaining, etc.

by TZubiri an hour ago

dependencies that themselves are targets for deletion

by Spivak an hour ago

What you're describing is using a parser generator to take a regex and turn it into code you can embed into your project. This already exists and you can use it now. https://re2c.org/

Data from: Hacker News, provided by Hacker News (unofficial) API